[lkml]   [2020]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 2/2] drm/sun4i: Use CRTC size instead of PRIMARY plane size as mixer frame.

On Wed, Jan 01, 2020 at 10:47:50PM +0200, wrote:
> From: Roman Stratiienko <>
> According to DRM documentation the only difference between PRIMARY
> and OVERLAY plane is that each CRTC must have PRIMARY plane and
> OVERLAY are optional.
> Allow PRIMARY plane to have dimension different from full-screen.
> Fixes: 5bb5f5dafa1a ("drm/sun4i: Reorganize UI layer code in DE2")
> Signed-off-by: Roman Stratiienko <>

So it applies to all the 4 patches you've sent, but this lacks some

There's a few questions that should be answered here:
- Which situation is it fixing?
- What tool / userspace stack is it fixing?
- What happens with your fix? Do you set the plane at coordinates
0,0 (meaning you'll crop the top-lef corner), do you center it? If
the plane is smaller than the CTRC size, what is set on the edges?

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2020-01-02 11:08    [W:0.076 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site