Messages in this thread | | | Date | Thu, 2 Jan 2020 11:08:32 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v3 2/2] drm/sun4i: Use CRTC size instead of PRIMARY plane size as mixer frame. |
| |
Hi,
On Wed, Jan 01, 2020 at 10:47:50PM +0200, roman.stratiienko@globallogic.com wrote: > From: Roman Stratiienko <roman.stratiienko@globallogic.com> > > According to DRM documentation the only difference between PRIMARY > and OVERLAY plane is that each CRTC must have PRIMARY plane and > OVERLAY are optional. > > Allow PRIMARY plane to have dimension different from full-screen. > > Fixes: 5bb5f5dafa1a ("drm/sun4i: Reorganize UI layer code in DE2") > Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
So it applies to all the 4 patches you've sent, but this lacks some context.
There's a few questions that should be answered here: - Which situation is it fixing? - What tool / userspace stack is it fixing? - What happens with your fix? Do you set the plane at coordinates 0,0 (meaning you'll crop the top-lef corner), do you center it? If the plane is smaller than the CTRC size, what is set on the edges?
Thanks! Maxime [unhandled content-type:application/pgp-signature] | |