lkml.org 
[lkml]   [2020]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 174/191] net/dst: do not confirm neighbor for vxlan and geneve pmtu update
    Date
    From: Hangbin Liu <liuhangbin@gmail.com>

    [ Upstream commit f081042d128a0c7acbd67611def62e1b52e2d294 ]

    When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
    we should not call dst_confirm_neigh() as there is no two-way communication.

    So disable the neigh confirm for vxlan and geneve pmtu update.

    v5: No change.
    v4: No change.
    v3: Do not remove dst_confirm_neigh, but add a new bool parameter in
    dst_ops.update_pmtu to control whether we should do neighbor confirm.
    Also split the big patch to small ones for each area.
    v2: Remove dst_confirm_neigh in __ip6_rt_update_pmtu.

    Fixes: a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path")
    Fixes: 52a589d51f10 ("geneve: update skb dst pmtu on tx path")
    Reviewed-by: Guillaume Nault <gnault@redhat.com>
    Tested-by: Guillaume Nault <gnault@redhat.com>
    Acked-by: David Ahern <dsahern@gmail.com>
    Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    include/net/dst.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/net/dst.h
    +++ b/include/net/dst.h
    @@ -535,7 +535,7 @@ static inline void skb_tunnel_check_pmtu
    u32 encap_mtu = dst_mtu(encap_dst);

    if (skb->len > encap_mtu - headroom)
    - skb_dst_update_pmtu(skb, encap_mtu - headroom);
    + skb_dst_update_pmtu_no_confirm(skb, encap_mtu - headroom);
    }

    #endif /* _NET_DST_H */

    \
     
     \ /
      Last update: 2020-01-02 23:56    [W:2.481 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site