lkml.org 
[lkml]   [2020]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 048/114] libnvdimm/btt: fix variable rc set but not used
    Date
    From: Qian Cai <cai@lca.pw>

    [ Upstream commit 4e24e37d5313edca8b4ab86f240c046c731e28d6 ]

    drivers/nvdimm/btt.c: In function 'btt_read_pg':
    drivers/nvdimm/btt.c:1264:8: warning: variable 'rc' set but not used
    [-Wunused-but-set-variable]
    int rc;
    ^~

    Add a ratelimited message in case a storm of errors is encountered.

    Fixes: d9b83c756953 ("libnvdimm, btt: rework error clearing")
    Signed-off-by: Qian Cai <cai@lca.pw>
    Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
    Link: https://lore.kernel.org/r/1572530719-32161-1-git-send-email-cai@lca.pw
    Signed-off-by: Dan Williams <dan.j.williams@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/nvdimm/btt.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
    index 0360c015f658..75ae2c508a04 100644
    --- a/drivers/nvdimm/btt.c
    +++ b/drivers/nvdimm/btt.c
    @@ -1260,11 +1260,11 @@ static int btt_read_pg(struct btt *btt, struct bio_integrity_payload *bip,

    ret = btt_data_read(arena, page, off, postmap, cur_len);
    if (ret) {
    - int rc;
    -
    /* Media error - set the e_flag */
    - rc = btt_map_write(arena, premap, postmap, 0, 1,
    - NVDIMM_IO_ATOMIC);
    + if (btt_map_write(arena, premap, postmap, 0, 1, NVDIMM_IO_ATOMIC))
    + dev_warn_ratelimited(to_dev(arena),
    + "Error persistently tracking bad blocks at %#x\n",
    + premap);
    goto out_rtt;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-02 23:55    [W:4.074 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site