lkml.org 
[lkml]   [2020]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 01/45] KVM: PPC: Book3S HV: Uninit vCPU if vcore creation fails
    On Wed, Dec 18, 2019 at 01:54:46PM -0800, Sean Christopherson wrote:
    > Call kvm_vcpu_uninit() if vcore creation fails to avoid leaking any
    > resources allocated by kvm_vcpu_init(), i.e. the vcpu->run page.
    >
    > Fixes: 371fefd6f2dc4 ("KVM: PPC: Allow book3s_hv guests to use SMT processor modes")
    > Cc: stable@vger.kernel.org
    > Reviewed-by: Greg Kurz <groug@kaod.org>
    > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
    > ---
    > arch/powerpc/kvm/book3s_hv.c | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)
    >
    > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
    > index dc53578193ee..d07d2f5273e5 100644
    > --- a/arch/powerpc/kvm/book3s_hv.c
    > +++ b/arch/powerpc/kvm/book3s_hv.c
    > @@ -2368,7 +2368,7 @@ static struct kvm_vcpu *kvmppc_core_vcpu_create_hv(struct kvm *kvm,
    > mutex_unlock(&kvm->lock);
    >
    > if (!vcore)
    > - goto free_vcpu;
    > + goto uninit_vcpu;
    >
    > spin_lock(&vcore->lock);
    > ++vcore->num_threads;
    > @@ -2385,6 +2385,8 @@ static struct kvm_vcpu *kvmppc_core_vcpu_create_hv(struct kvm *kvm,
    >
    > return vcpu;
    >
    > +uninit_vcpu:
    > + kvm_vcpu_uninit(vcpu);
    > free_vcpu:
    > kmem_cache_free(kvm_vcpu_cache, vcpu);
    > out:
    > --
    > 2.24.1

    Looks correct.

    Acked-by: Paul Mackerras <paulus@ozlabs.org>

    \
     
     \ /
      Last update: 2020-01-20 04:35    [W:4.734 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site