lkml.org 
[lkml]   [2020]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 1/8] scsi: ufs: Fix ufshcd_probe_hba() reture value in case ufshcd_scsi_add_wlus() fails
    Date
    From: Bean Huo <beanhuo@micron.com>

    A non-zero error value likely being returned by ufshcd_scsi_add_wlus()
    in case of failure of adding the WLs, but ufshcd_probe_hba() doesn't
    use this value, and doesn't report this failure to upper caller.
    This patch is to fix this issue.

    Fixes: 2a8fa600445c ("ufs: manually add well known logical units")
    Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
    Signed-off-by: Bean Huo <beanhuo@micron.com>
    ---
    drivers/scsi/ufs/ufshcd.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
    index bea036ab189a..9a9085a7bcc5 100644
    --- a/drivers/scsi/ufs/ufshcd.c
    +++ b/drivers/scsi/ufs/ufshcd.c
    @@ -7032,7 +7032,8 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
    ufshcd_init_icc_levels(hba);

    /* Add required well known logical units to scsi mid layer */
    - if (ufshcd_scsi_add_wlus(hba))
    + ret = ufshcd_scsi_add_wlus(hba);
    + if (ret)
    goto out;

    /* Initialize devfreq after UFS device is detected */
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-01-19 01:14    [W:4.368 / U:0.684 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site