Messages in this thread | | | Subject | Re: [PATCH v10 2/8] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations | From | Mike Kravetz <> | Date | Fri, 17 Jan 2020 11:26:24 -0800 |
| |
On 1/14/20 5:26 PM, Mina Almasry wrote: > Augments hugetlb_cgroup_charge_cgroup to be able to charge hugetlb > usage or hugetlb reservation counter. > > Adds a new interface to uncharge a hugetlb_cgroup counter via > hugetlb_cgroup_uncharge_counter. > > Integrates the counter with hugetlb_cgroup, via hugetlb_cgroup_init, > hugetlb_cgroup_have_usage, and hugetlb_cgroup_css_offline. > > Signed-off-by: Mina Almasry <almasrymina@google.com> > > --- > > Changes in v10: > - Added missing VM_BUG_ON
Thanks for addressing my comments. I see that patch 8 was updated to address David's comments. I will also review patch 8 later.
I am again requesting that someone with more cgroup experience comment on this patch. I do not have enough experience to determine if the code to not reparent/zombie cgroup is correct.
For now, Acked-by: Mike Kravetz <mike.kravetz@oracle.com> while waiting for cgroup comments.
-- Mike Kravetz
| |