lkml.org 
[lkml]   [2020]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] microblaze: Wire CMA allocator
From
Date
On 14. 01. 20 16:47, Christoph Hellwig wrote:
> On Tue, Jan 14, 2020 at 12:57:28PM +0100, Michal Simek wrote:
>> Based on commit 04e3543e228f ("microblaze: use the generic dma coherent remap allocator")
>> CMA can be easily enabled by calling dma_contiguous_reserve() at the end of
>> mmu_init(). High limit is end of lowmem space which is completely unused at
>> this point of time.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Christoph: Can you please review this patch?
>
> Looks sensible to me. If you touch this area anyway I have a request,
> though:
>
>> +++ b/arch/microblaze/include/asm/Kbuild
>> @@ -7,6 +7,7 @@ generic-y += bugs.h
>> generic-y += compat.h
>> generic-y += device.h
>> generic-y += div64.h
>> +generic-y += dma-contiguous.h
>
> Can you add a prep patch to add a
>
> mandatory-y += dma-contiguous.h
>
> to include/asm-generic/Kbuild and remove the generic-y in all the
> arch files? That reduces the arch churn a little.

Sure not a problem.
M



\
 
 \ /
  Last update: 2020-01-17 08:53    [W:0.051 / U:2.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site