Messages in this thread | | | Subject | Re: [PATCH] microblaze: Wire CMA allocator | From | Michal Simek <> | Date | Fri, 17 Jan 2020 08:51:41 +0100 |
| |
On 14. 01. 20 16:47, Christoph Hellwig wrote: > On Tue, Jan 14, 2020 at 12:57:28PM +0100, Michal Simek wrote: >> Based on commit 04e3543e228f ("microblaze: use the generic dma coherent remap allocator") >> CMA can be easily enabled by calling dma_contiguous_reserve() at the end of >> mmu_init(). High limit is end of lowmem space which is completely unused at >> this point of time. >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> Christoph: Can you please review this patch? > > Looks sensible to me. If you touch this area anyway I have a request, > though: > >> +++ b/arch/microblaze/include/asm/Kbuild >> @@ -7,6 +7,7 @@ generic-y += bugs.h >> generic-y += compat.h >> generic-y += device.h >> generic-y += div64.h >> +generic-y += dma-contiguous.h > > Can you add a prep patch to add a > > mandatory-y += dma-contiguous.h > > to include/asm-generic/Kbuild and remove the generic-y in all the > arch files? That reduces the arch churn a little.
Sure not a problem. M
| |