lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/tsc: Add tsc_guess flag disabling CPUID.16h use for tsc calibration
Hi Krzysztof,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/auto-latest]
[also build test ERROR on linux/master tip/x86/core linus/master v5.5-rc6 next-20200110]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Krzysztof-Piecuch/x86-tsc-Add-tsc_guess-flag-disabling-CPUID-16h-use-for-tsc-calibration/20200115-111400
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 425cc0b850aaaa121b4ddf32c029a72e7a260dfb
config: x86_64-randconfig-c002-20200115 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> arch/x86//kernel/tsc.c:62:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'tsc_guess'
static bool _read_mostly tsc_guess = 1;
^~~~~~~~~
arch/x86//kernel/tsc.c: In function 'tsc_guess_setup':
>> arch/x86//kernel/tsc.c:65:25: error: 'tsc_guess' undeclared (first use in this function); did you mean 'tss_desc'?
return strtobool(buf, &tsc_guess);
^~~~~~~~~
tss_desc
arch/x86//kernel/tsc.c:65:25: note: each undeclared identifier is reported only once for each function it appears in
arch/x86//kernel/tsc.c: In function 'native_calibrate_tsc':
arch/x86//kernel/tsc.c:664:26: error: 'tsc_guess' undeclared (first use in this function); did you mean 'tss_desc'?
if (crystal_khz == 0 && tsc_guess &&
^~~~~~~~~
tss_desc
arch/x86//kernel/tsc.c: In function 'cpu_khz_from_cpuid':
arch/x86//kernel/tsc.c:703:43: error: 'tsc_guess' undeclared (first use in this function); did you mean 'tss_desc'?
if (boot_cpu_data.cpuid_level < 0x16 || !tsc_guess)
^~~~~~~~~
tss_desc
arch/x86//kernel/tsc.c: In function 'tsc_guess_setup':
>> arch/x86//kernel/tsc.c:66:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^

vim +62 arch/x86//kernel/tsc.c

61
> 62 static bool _read_mostly tsc_guess = 1;
63 static int __init tsc_guess_setup(char *buf)
64 {
> 65 return strtobool(buf, &tsc_guess);
> 66 }
67 early_param("tsc_guess", tsc_guess_setup);
68

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-01-16 08:40    [W:1.469 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site