lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 110/205] regulator: ab8500: Remove SYSCLKREQ from enum ab8505_regulator_id
    Date
    From: Stephan Gerhold <stephan@gerhold.net>

    [ Upstream commit 458ea3ad033fc86e291712ce50cbe60c3428cf30 ]

    Those regulators are not actually supported by the AB8500 regulator
    driver. There is no ab8500_regulator_info for them and no entry in
    ab8505_regulator_match.

    As such, they cannot be registered successfully, and looking them
    up in ab8505_regulator_match causes an out-of-bounds array read.

    Fixes: 547f384f33db ("regulator: ab8500: add support for ab8505")
    Cc: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Link: https://lore.kernel.org/r/20191106173125.14496-2-stephan@gerhold.net
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/linux/regulator/ab8500.h | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/include/linux/regulator/ab8500.h b/include/linux/regulator/ab8500.h
    index 505e94a6e3e8..3ab1ddf151a2 100644
    --- a/include/linux/regulator/ab8500.h
    +++ b/include/linux/regulator/ab8500.h
    @@ -42,8 +42,6 @@ enum ab8505_regulator_id {
    AB8505_LDO_ANAMIC2,
    AB8505_LDO_AUX8,
    AB8505_LDO_ANA,
    - AB8505_SYSCLKREQ_2,
    - AB8505_SYSCLKREQ_4,
    AB8505_NUM_REGULATORS,
    };

    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 17:53    [W:4.051 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site