Messages in this thread | | | Date | Thu, 16 Jan 2020 13:33:47 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v6 2/3] mfd: cros_ec: Add cros-usbpd-notify subdevice |
| |
On Tue, 14 Jan 2020, Prashant Malani wrote:
> Add the cros-usbpd-notify driver as a subdevice on platforms that > support the EC_FEATURE_USB_PD EC feature flag and don't have the > ACPI PD notification device defined. > > This driver allows other cros-ec devices to receive PD event > notifications from the Chrome OS Embedded Controller (EC) via a > notification chain. > > Signed-off-by: Prashant Malani <pmalani@chromium.org> > --- > > Changes in v6: > - No changes.
Just replied to v5:
Looks good to me. Could we have some Chromium reviews please?
> Changes in v5: > - Updated the IS_ENABLED() check to check for CONFIG_OF instead of > !CONFIG_ACPI according to upstream comments. > > Changes in v4: > - Removed #ifndef usage; instead, moved cros-usbpd-notify to a separate > mfd_cell and used an IS_ENABLED() check. > - Changed commit title and description slightly to reflect change in > code. > drivers/mfd/cros_ec_dev.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+)
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |