lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] usb: gadget: xudc: Remove redundant platform_get_irq error message
From
Date
Reviewed-by: Nagarjuna Kristam <nkristam@nvidia.com>

On 16-01-2020 19:44, YueHaibing wrote:
> External email: Use caution opening links or attachments
>
>
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
> index 634c2c1..fc1eafc 100644
> --- a/drivers/usb/gadget/udc/tegra-xudc.c
> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
> @@ -3492,11 +3492,8 @@ static int tegra_xudc_probe(struct platform_device *pdev)
> }
>
> xudc->irq = platform_get_irq(pdev, 0);
> - if (xudc->irq < 0) {
> - dev_err(xudc->dev, "failed to get IRQ: %d\n",
> - xudc->irq);
> + if (xudc->irq < 0)
> return xudc->irq;
> - }
>
> err = devm_request_irq(&pdev->dev, xudc->irq, tegra_xudc_irq, 0,
> dev_name(&pdev->dev), xudc);
> --
> 2.7.4
>
>

\
 
 \ /
  Last update: 2020-01-17 05:05    [W:0.098 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site