Messages in this thread Patch in this message | | | From | Jiaxun Yang <> | Subject | [PATCH v1 2/2] irqchip: mips-cpu: Drop unnecessary ack/eoi operations | Date | Fri, 17 Jan 2020 08:17:06 +0800 |
| |
Actually, all MIPS processor interrupt lines are level triggered. So providing ack/eoi operation could lead to some unexpected results, Like chained IRQ handeler failed to mask upstream CPU IRQ.
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> --- drivers/irqchip/irq-mips-cpu.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/irqchip/irq-mips-cpu.c b/drivers/irqchip/irq-mips-cpu.c index 95d4fd8f7a96..e34f4317bb88 100644 --- a/drivers/irqchip/irq-mips-cpu.c +++ b/drivers/irqchip/irq-mips-cpu.c @@ -51,11 +51,9 @@ static inline void mask_mips_irq(struct irq_data *d) static struct irq_chip mips_cpu_irq_controller = { .name = "MIPS", - .irq_ack = mask_mips_irq, .irq_mask = mask_mips_irq, .irq_mask_ack = mask_mips_irq, .irq_unmask = unmask_mips_irq, - .irq_eoi = unmask_mips_irq, .irq_disable = mask_mips_irq, .irq_enable = unmask_mips_irq, }; @@ -112,11 +110,9 @@ static void mips_mt_send_ipi(struct irq_data *d, unsigned int cpu) static struct irq_chip mips_mt_cpu_irq_controller = { .name = "MIPS", .irq_startup = mips_mt_cpu_irq_startup, - .irq_ack = mips_mt_cpu_irq_ack, .irq_mask = mask_mips_irq, .irq_mask_ack = mips_mt_cpu_irq_ack, .irq_unmask = unmask_mips_irq, - .irq_eoi = unmask_mips_irq, .irq_disable = mask_mips_irq, .irq_enable = unmask_mips_irq, #ifdef CONFIG_GENERIC_IRQ_IPI -- 2.24.1
| |