lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 017/203] mtd: onenand: omap2: Pass correct flags for prep_dma_memcpy
    Date
    From: Peter Ujfalusi <peter.ujfalusi@ti.com>

    commit 8bcef0d54067077cf9a6cb129022c77559926e8c upstream.

    The commit converting the driver to DMAengine was missing the flags for
    the memcpy prepare call.
    It went unnoticed since the omap-dma driver was ignoring them.

    Fixes: 3ed6a4d1de2c5 (" mtd: onenand: omap2: Convert to use dmaengine for memcp")
    Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
    Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
    Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
    Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/nand/onenand/omap2.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/mtd/nand/onenand/omap2.c
    +++ b/drivers/mtd/nand/onenand/omap2.c
    @@ -328,7 +328,8 @@ static inline int omap2_onenand_dma_tran
    struct dma_async_tx_descriptor *tx;
    dma_cookie_t cookie;

    - tx = dmaengine_prep_dma_memcpy(c->dma_chan, dst, src, count, 0);
    + tx = dmaengine_prep_dma_memcpy(c->dma_chan, dst, src, count,
    + DMA_CTRL_ACK | DMA_PREP_INTERRUPT);
    if (!tx) {
    dev_err(&c->pdev->dev, "Failed to prepare DMA memcpy\n");
    return -EIO;

    \
     
     \ /
      Last update: 2020-01-17 00:48    [W:4.023 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site