lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 25/84] iommu: Remove device link to group on failure
    Date
    From: Jon Derrick <jonathan.derrick@intel.com>

    commit 7d4e6ccd1fb09dbfbc49746ca82bd5c25ad4bfe4 upstream.

    This adds the missing teardown step that removes the device link from
    the group when the device addition fails.

    Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
    Fixes: 797a8b4d768c5 ("iommu: Handle default domain attach failure")
    Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
    Signed-off-by: Joerg Roedel <jroedel@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iommu/iommu.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/iommu/iommu.c
    +++ b/drivers/iommu/iommu.c
    @@ -650,6 +650,7 @@ err_put_group:
    mutex_unlock(&group->mutex);
    dev->iommu_group = NULL;
    kobject_put(group->devices_kobj);
    + sysfs_remove_link(group->devices_kobj, device->name);
    err_free_name:
    kfree(device->name);
    err_remove_link:

    \
     
     \ /
      Last update: 2020-01-17 00:39    [W:7.354 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site