lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/vmscan: remove prefetch_prev_lru_page
On Thu, 16 Jan 2020 07:26:23 -0500 Qian Cai <cai@lca.pw> wrote:

>
>
> > On Jan 14, 2020, at 9:33 PM, Alex Shi <alex.shi@linux.alibaba.com> wrote:
> >
> > 
> >
> >> 在 2020/1/14 下午9:46, Qian Cai 写道:
> >>
> >>
> >>>> On Jan 14, 2020, at 7:55 AM, Alex Shi <alex.shi@linux.alibaba.com> wrote:
> >>>
> >>> This macro are never used in git history. So better to remove.
> >>
> >> When removing unused thingy, it is important to figure out which commit introduced it in the first place and Cc the relevant people in that commit.
> >>
> >
> > Thanks fore reminder, Qian!
> >
> > This macro was introduced in 1da177e4c3f4 Linux-2.6.12-rc2, no author or commiter could be found.
>
> Looks a bit deeper for this, and I am not sure if it is necessary to remove it especially this does not cause any complication warning noise, because the macro looks like a part of API design to have a pair of both read and write version, even though only the write version is used at the moment.
>
> In theory, there could be users for the read version in the future, and then it needs to be added back.

Sure. A problem with leaving it in place is that this leads people to
assume it is tested, which it presumably is not.

I don't think there's any particular downside either way, really. But
it's presently cruft so I'm inclined to remove it. If someone has a
need then they can add it back (presumbly reimplement it, actually) and
test it then.

\
 
 \ /
  Last update: 2020-01-17 00:37    [W:0.057 / U:22.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site