lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 15/84] dccp: Fix memleak in __feat_register_sp
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    commit 1d3ff0950e2b40dc861b1739029649d03f591820 upstream.

    If dccp_feat_push_change fails, we forget free the mem
    which is alloced by kmemdup in dccp_feat_clone_sp_val.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
    Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/dccp/feat.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    --- a/net/dccp/feat.c
    +++ b/net/dccp/feat.c
    @@ -738,7 +738,12 @@ static int __feat_register_sp(struct lis
    if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
    return -ENOMEM;

    - return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
    + if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
    + kfree(fval.sp.vec);
    + return -ENOMEM;
    + }
    +
    + return 0;
    }

    /**

    \
     
     \ /
      Last update: 2020-01-17 00:28    [W:5.110 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site