lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH][next] staging: wilc1000: remove redundant assignment to variable result
Date


On 14.01.2020 19:27, Colin King wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable result is being initialized with a value that
> is never read and is being re-assigned later on. The assignment
> is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

> ---
> drivers/staging/wilc1000/spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/spi.c b/drivers/staging/wilc1000/spi.c
> index 55f8757325f0..8694ab5fcb22 100644
> --- a/drivers/staging/wilc1000/spi.c
> +++ b/drivers/staging/wilc1000/spi.c
> @@ -733,7 +733,7 @@ static int spi_internal_read(struct wilc *wilc, u32 adr, u32 *data)
> static int wilc_spi_write_reg(struct wilc *wilc, u32 addr, u32 data)
> {
> struct spi_device *spi = to_spi_device(wilc->dev);
> - int result = N_OK;
> + int result;
> u8 cmd = CMD_SINGLE_WRITE;
> u8 clockless = 0;
>
> @@ -782,7 +782,7 @@ static int wilc_spi_write(struct wilc *wilc, u32 addr, u8 *buf, u32 size)
> static int wilc_spi_read_reg(struct wilc *wilc, u32 addr, u32 *data)
> {
> struct spi_device *spi = to_spi_device(wilc->dev);
> - int result = N_OK;
> + int result;
> u8 cmd = CMD_SINGLE_READ;
> u8 clockless = 0;
>
> --
> 2.24.0
>
>
\
 
 \ /
  Last update: 2020-01-16 12:10    [W:0.055 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site