lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 041/671] drm/sun4i: hdmi: Fix double flag assignation
    Date
    From: Maxime Ripard <maxime.ripard@bootlin.com>

    [ Upstream commit 1e0ff648940e603cab6c52cf3723017d30d78f30 ]

    The is_double flag is a boolean currently assigned to the value of the d
    variable, that is either 1 or 2. It means that this is_double variable is
    always set to true, even though the initial intent was to have it set to
    true when d is 2.

    Fix this.

    Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support")
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
    Reviewed-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20181021163446.29135-2-maxime.ripard@bootlin.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c
    index 3ecffa52c814..a74adec6c5dc 100644
    --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c
    +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c
    @@ -52,7 +52,7 @@ static unsigned long sun4i_tmds_calc_divider(unsigned long rate,
    (rate - tmp_rate) < (rate - best_rate)) {
    best_rate = tmp_rate;
    best_m = m;
    - is_double = d;
    + is_double = (d == 2) ? true : false;
    }
    }
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 20:16    [W:4.093 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site