lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 063/671] mailbox: ti-msgmgr: Off by one in ti_msgmgr_of_xlate()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 78f3ff524fca63e7d2a57149a34ade23d2c12798 ]

    The > comparison should be >= or we access one element beyond the end
    of the array.

    (The inst->qinsts[] array is allocated in the ti_msgmgr_probe() function
    and it has ->num_valid_queues elements.)

    Fixes: a2b79838b891 ("mailbox: ti-msgmgr: Add support for Secure Proxy")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Nishanth Menon <nm@ti.com>
    Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mailbox/ti-msgmgr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c
    index 5bceafbf6699..01e9e462512b 100644
    --- a/drivers/mailbox/ti-msgmgr.c
    +++ b/drivers/mailbox/ti-msgmgr.c
    @@ -547,7 +547,7 @@ static struct mbox_chan *ti_msgmgr_of_xlate(struct mbox_controller *mbox,
    }

    if (d->is_sproxy) {
    - if (req_pid > d->num_valid_queues)
    + if (req_pid >= d->num_valid_queues)
    goto err;
    qinst = &inst->qinsts[req_pid];
    return qinst->chan;
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 20:15    [W:4.099 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site