lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 280/671] bpf: Add missed newline in verifier verbose log
    Date
    From: Andrey Ignatov <rdna@fb.com>

    [ Upstream commit 1fbd20f8b77b366ea4aeb92ade72daa7f36a7e3b ]

    check_stack_access() that prints verbose log is used in
    adjust_ptr_min_max_vals() that prints its own verbose log and now they
    stick together, e.g.:

    variable stack access var_off=(0xfffffffffffffff0; 0x4) off=-16
    size=1R2 stack pointer arithmetic goes out of range, prohibited for
    !root

    Add missing newline so that log is more readable:
    variable stack access var_off=(0xfffffffffffffff0; 0x4) off=-16 size=1
    R2 stack pointer arithmetic goes out of range, prohibited for !root

    Fixes: f1174f77b50c ("bpf/verifier: rework value tracking")
    Signed-off-by: Andrey Ignatov <rdna@fb.com>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/bpf/verifier.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
    index 9e72b2f8c3dd..0952049b5ff1 100644
    --- a/kernel/bpf/verifier.c
    +++ b/kernel/bpf/verifier.c
    @@ -1253,7 +1253,7 @@ static int check_stack_access(struct bpf_verifier_env *env,
    char tn_buf[48];

    tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
    - verbose(env, "variable stack access var_off=%s off=%d size=%d",
    + verbose(env, "variable stack access var_off=%s off=%d size=%d\n",
    tn_buf, off, size);
    return -EACCES;
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 20:03    [W:4.130 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site