lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 393/671] phy: qcom-qusb2: fix missing assignment of ret when calling clk_prepare_enable
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit d98010817a26eba8d4d1e8a639e0b7d7f042308a ]

    The error return from the call to clk_prepare_enable is not being assigned
    to variable ret even though ret is being used to check if the call failed.
    Fix this by adding in the missing assignment.

    Addresses-Coverity: ("Logically dead code")
    Fixes: 891a96f65ac3 ("phy: qcom-qusb2: Add support for runtime PM")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
    index 69c92843eb3b..9b7ae93e9df1 100644
    --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
    +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
    @@ -526,7 +526,7 @@ static int __maybe_unused qusb2_phy_runtime_resume(struct device *dev)
    }

    if (!qphy->has_se_clk_scheme) {
    - clk_prepare_enable(qphy->ref_clk);
    + ret = clk_prepare_enable(qphy->ref_clk);
    if (ret) {
    dev_err(dev, "failed to enable ref clk, %d\n", ret);
    goto disable_ahb_clk;
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 19:53    [W:4.584 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site