lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 563/671] net: hisilicon: Fix signedness bug in hix5hd2_dev_probe()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 002dfe8085255b7bf1e0758c3d195c5412d35be9 ]

    The "priv->phy_mode" variable is an enum and in this context GCC will
    treat it as unsigned to the error handling will never trigger.

    Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
    index 471805ea363b..b63871ef8a40 100644
    --- a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
    +++ b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
    @@ -1201,7 +1201,7 @@ static int hix5hd2_dev_probe(struct platform_device *pdev)
    goto err_free_mdio;

    priv->phy_mode = of_get_phy_mode(node);
    - if (priv->phy_mode < 0) {
    + if ((int)priv->phy_mode < 0) {
    netdev_err(ndev, "not find phy-mode\n");
    ret = -EINVAL;
    goto err_mdiobus;
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 19:41    [W:2.971 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site