lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 137/371] media: ivtv: update *pos correctly in ivtv_read_pos()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit f8e579f3ca0973daef263f513da5edff520a6c0d ]

    We had intended to update *pos, but the current code is a no-op.

    Fixes: 1a0adaf37c30 ("V4L/DVB (5345): ivtv driver for Conexant cx23416/cx23415 MPEG encoder/decoder")

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/pci/ivtv/ivtv-fileops.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/pci/ivtv/ivtv-fileops.c b/drivers/media/pci/ivtv/ivtv-fileops.c
    index c9bd018e53de..e2b19c3eaa87 100644
    --- a/drivers/media/pci/ivtv/ivtv-fileops.c
    +++ b/drivers/media/pci/ivtv/ivtv-fileops.c
    @@ -420,7 +420,7 @@ static ssize_t ivtv_read_pos(struct ivtv_stream *s, char __user *ubuf, size_t co

    IVTV_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc);
    if (rc > 0)
    - pos += rc;
    + *pos += rc;
    return rc;
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 19:29    [W:4.125 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site