lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 190/371] vfio/mdev: Avoid release parent reference during error path
    Date
    From: Parav Pandit <parav@mellanox.com>

    [ Upstream commit 60e7f2c3fe9919cee9534b422865eed49f4efb15 ]

    During mdev parent registration in mdev_register_device(),
    if parent device is duplicate, it releases the reference of existing
    parent device.
    This is incorrect. Existing parent device should not be touched.

    Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
    Reviewed-by: Cornelia Huck <cohuck@redhat.com>
    Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>
    Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
    Signed-off-by: Parav Pandit <parav@mellanox.com>
    Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/vfio/mdev/mdev_core.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c
    index 0212f0ee8aea..8cfa71230877 100644
    --- a/drivers/vfio/mdev/mdev_core.c
    +++ b/drivers/vfio/mdev/mdev_core.c
    @@ -182,6 +182,7 @@ int mdev_register_device(struct device *dev, const struct mdev_parent_ops *ops)
    /* Check for duplicate */
    parent = __find_parent_device(dev);
    if (parent) {
    + parent = NULL;
    ret = -EEXIST;
    goto add_dev_err;
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 19:25    [W:4.078 / U:1.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site