lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.4 114/174] x86/kgbd: Use NMI_VECTOR not APIC_DM_NMI
    Date
    From: Thomas Gleixner <tglx@linutronix.de>

    [ Upstream commit 2591bc4e8d70b4e1330d327fb7e3921f4e070a51 ]

    apic->send_IPI_allbutself() takes a vector number as argument.

    APIC_DM_NMI is clearly not a vector number. It's defined to 0x400 which is
    outside the vector space.

    Use NMI_VECTOR instead as that's what it is intended to be.

    Fixes: 82da3ff89dc2 ("x86: kgdb support")
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Link: https://lkml.kernel.org/r/20190722105218.855189979@linutronix.de
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/x86/kernel/kgdb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
    index 44256a62702b..4a08fda2b06f 100644
    --- a/arch/x86/kernel/kgdb.c
    +++ b/arch/x86/kernel/kgdb.c
    @@ -437,7 +437,7 @@ static void kgdb_disable_hw_debug(struct pt_regs *regs)
    */
    void kgdb_roundup_cpus(unsigned long flags)
    {
    - apic->send_IPI_allbutself(APIC_DM_NMI);
    + apic->send_IPI_allbutself(NMI_VECTOR);
    }
    #endif

    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 18:52    [W:4.082 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site