lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 161/251] clk: qcom: Fix -Wunused-const-variable
    Date
    From: Nathan Huckleberry <nhuck@google.com>

    [ Upstream commit da642427bd7710ec4f4140f693f59aa8521a358c ]

    Clang produces the following warning

    drivers/clk/qcom/gcc-msm8996.c:133:32: warning: unused variable
    'gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map' [-Wunused-const-variable]
    static const struct
    parent_map gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map[] =
    { ^drivers/clk/qcom/gcc-msm8996.c:141:27: warning: unused variable
    'gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div' [-Wunused-const-variable] static
    const char * const gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div[] = { ^
    drivers/clk/qcom/gcc-msm8996.c:187:32: warning: unused variable
    'gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map'
    [-Wunused-const-variable] static const struct parent_map
    gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map[] = { ^
    drivers/clk/qcom/gcc-msm8996.c:197:27: warning: unused variable
    'gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div'
    [-Wunused-const-variable] static const char * const
    gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div[] = {

    It looks like these were never used.

    Fixes: b1e010c0730a ("clk: qcom: Add MSM8996 Global Clock Control (GCC) driver")
    Cc: clang-built-linux@googlegroups.com
    Link: https://github.com/ClangBuiltLinux/linux/issues/518
    Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: Nathan Huckleberry <nhuck@google.com>
    Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/qcom/gcc-msm8996.c | 36 ----------------------------------
    1 file changed, 36 deletions(-)

    diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c
    index fe03e6fbc7df..ea6c227331fc 100644
    --- a/drivers/clk/qcom/gcc-msm8996.c
    +++ b/drivers/clk/qcom/gcc-msm8996.c
    @@ -140,22 +140,6 @@ static const char * const gcc_xo_gpll0_gpll4_gpll0_early_div[] = {
    "gpll0_early_div"
    };

    -static const struct parent_map gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div_map[] = {
    - { P_XO, 0 },
    - { P_GPLL0, 1 },
    - { P_GPLL2, 2 },
    - { P_GPLL3, 3 },
    - { P_GPLL0_EARLY_DIV, 6 }
    -};
    -
    -static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll0_early_div[] = {
    - "xo",
    - "gpll0",
    - "gpll2",
    - "gpll3",
    - "gpll0_early_div"
    -};
    -
    static const struct parent_map gcc_xo_gpll0_gpll1_early_div_gpll1_gpll4_gpll0_early_div_map[] = {
    { P_XO, 0 },
    { P_GPLL0, 1 },
    @@ -194,26 +178,6 @@ static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll2_early_gpll0_early
    "gpll0_early_div"
    };

    -static const struct parent_map gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div_map[] = {
    - { P_XO, 0 },
    - { P_GPLL0, 1 },
    - { P_GPLL2, 2 },
    - { P_GPLL3, 3 },
    - { P_GPLL1, 4 },
    - { P_GPLL4, 5 },
    - { P_GPLL0_EARLY_DIV, 6 }
    -};
    -
    -static const char * const gcc_xo_gpll0_gpll2_gpll3_gpll1_gpll4_gpll0_early_div[] = {
    - "xo",
    - "gpll0",
    - "gpll2",
    - "gpll3",
    - "gpll1",
    - "gpll4",
    - "gpll0_early_div"
    -};
    -
    static struct clk_fixed_factor xo = {
    .mult = 1,
    .div = 1,
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 18:41    [W:4.090 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site