lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 043/251] ASoC: imx-sgtl5000: put of nodes if finding codec fails
    Date
    From: Stefan Agner <stefan@agner.ch>

    [ Upstream commit d9866572486802bc598a3e8576a5231378d190de ]

    Make sure to properly put the of node in case finding the codec
    fails.

    Fixes: 81e8e4926167 ("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000")
    Signed-off-by: Stefan Agner <stefan@agner.ch>
    Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
    Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
    Reviewed-by: Fabio Estevam <festevam@gmail.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/fsl/imx-sgtl5000.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
    index 8e525f7ac08d..3d99a8579c99 100644
    --- a/sound/soc/fsl/imx-sgtl5000.c
    +++ b/sound/soc/fsl/imx-sgtl5000.c
    @@ -119,7 +119,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
    codec_dev = of_find_i2c_device_by_node(codec_np);
    if (!codec_dev) {
    dev_err(&pdev->dev, "failed to find codec platform device\n");
    - return -EPROBE_DEFER;
    + ret = -EPROBE_DEFER;
    + goto fail;
    }

    data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 18:37    [W:3.796 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site