Messages in this thread | | | Subject | Re: [RESEND PATCHv4 01/14] dt-bindings: remoteproc: Add OMAP remoteproc bindings | From | Tero Kristo <> | Date | Thu, 16 Jan 2020 09:51:18 +0200 |
| |
On 08/01/2020 18:49, Suman Anna wrote: > Hi Tero, > > On 1/2/20 7:25 AM, Tero Kristo wrote: >> From: Suman Anna <s-anna@ti.com> >> >> Add the device tree bindings document for the IPU and DSP >> remote processor devices on OMAP4+ SoCs. >> >> Cc: Rob Herring <robh@kernel.org> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Suman Anna <s-anna@ti.com> >> [t-kristo@ti.com: converted to schema] >> Signed-off-by: Tero Kristo <t-kristo@ti.com> >> --- >> v4: added ti,bootreg-shift and ti,autosuspend-delay properties > > You missed out on my v3 comment on the firmware-name on Example 2. Can > you please address it when you post the next version?
I don't think I missed it, but you never told what is the actual name to use there. Firmware name generally does not matter, as user can provide whatever he wants via DT now.
-Tero
> >> >> .../remoteproc/ti,omap-remoteproc.yaml | 329 ++++++++++++++++++ >> 1 file changed, 329 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml >> new file mode 100644 >> index 000000000000..f53d58efaae3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml > > [snip] > >> + - |+ >> + >> + //Example 2: OMAP5 IPU >> + >> + /* IPU Reserved Memory node */ >> + #include <dt-bindings/clock/omap5.h> >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + ipu_memory_region: ipu-memory@95800000 { >> + compatible = "shared-dma-pool"; >> + reg = <0 0x95800000 0 0x3800000>; >> + reusable; >> + }; >> + }; >> + >> + /* IPU node */ >> + ocp { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + ipu: ipu@55020000 { >> + compatible = "ti,omap5-ipu"; >> + reg = <0x55020000 0x10000>; >> + reg-names = "l2ram"; >> + iommus = <&mmu_ipu>; >> + mboxes = <&mailbox &mbox_ipu>; >> + memory-region = <&ipu_memory_region>; >> + ti,timers = <&timer3>, <&timer4>; >> + ti,watchdog-timers = <&timer9>, <&timer11>; >> + clocks = <&ipu_clkctrl OMAP5_MMU_IPU_CLKCTRL 0>; >> + resets = <&prm_core 2>; >> + firmware-name = "omap5-ipu-fw.xem"; >> + }; >> + }; > > regards > Suman >
-- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
| |