lkml.org 
[lkml]   [2020]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -rcu] kcsan: Make KCSAN compatible with lockdep
On Tue, 14 Jan 2020 at 18:24, Alexander Potapenko <glider@google.com> wrote:
>
> > --- a/kernel/kcsan/core.c
> > +++ b/kernel/kcsan/core.c
> > @@ -337,7 +337,7 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type)
> > * detection point of view) to simply disable preemptions to ensure
> > * as many tasks as possible run on other CPUs.
> > */
> > - local_irq_save(irq_flags);
> > + raw_local_irq_save(irq_flags);
>
> Please reflect the need to use raw_local_irq_save() in the comment.
>
> >
> > watchpoint = insert_watchpoint((unsigned long)ptr, size, is_write);
> > if (watchpoint == NULL) {
> > @@ -429,7 +429,7 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type)
> >
> > kcsan_counter_dec(KCSAN_COUNTER_USED_WATCHPOINTS);
> > out_unlock:
> > - local_irq_restore(irq_flags);
> > + raw_local_irq_restore(irq_flags);
>
> Ditto

Done. v2: http://lkml.kernel.org/r/20200115162512.70807-1-elver@google.com

Thanks,
-- Marco

\
 
 \ /
  Last update: 2020-01-15 17:27    [W:1.451 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site