lkml.org 
[lkml]   [2020]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v10 03/14] exfat: add inode operations
2020-01-15 19:25 GMT+09:00, Arnd Bergmann <arnd@arndb.de>:
> On Wed, Jan 15, 2020 at 9:28 AM Namjae Jeon <namjae.jeon@samsung.com>
> wrote:
>
>> + /* set FILE_INFO structure using the acquired struct exfat_dentry
>> */
>> + exfat_set_entry_time(sbi, &inode->i_ctime,
>> + &ep->dentry.file.create_time,
>> + &ep->dentry.file.create_date,
>> + &ep->dentry.file.create_tz);
>> + exfat_set_entry_time(sbi, &inode->i_mtime,
>> + &ep->dentry.file.modify_time,
>> + &ep->dentry.file.modify_date,
>> + &ep->dentry.file.modify_tz);
>> + exfat_set_entry_time(sbi, &inode->i_atime,
>> + &ep->dentry.file.access_time,
>> + &ep->dentry.file.access_date,
>> + &ep->dentry.file.access_tz);
>
> I wonder if i_ctime should be handled differently. With statx() we finally
> have
> a concept of "file creation time" in "stx_btime". so it would make sense to
> store dentry.file.create_time in there rather than in i_ctime.
Right.
>
> It seems that traditionally most file systems that cannot store ctime
> separately
> just set i_ctime and i_mtime both to what is is modify_time here, though
> fat and hpfs use i_ctime to refer to creation time.
I will check it.

Thanks for your review!
>
> Arnd
>

\
 
 \ /
  Last update: 2020-01-15 14:41    [W:0.127 / U:2.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site