lkml.org 
[lkml]   [2020]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v10 00/14] add the latest exfat driver
2020-01-15 18:47 GMT+09:00, Pali Rohár <pali.rohar@gmail.com>:
> Hello! I have reviewed all changes in time when v10 has been preparing.
>
> There is just a small issue with description of EXFAT_DEFAULT_IOCHARSET
> option (see email). Otherwise it looks good you can add my Reviewed-by
> on whole patch series.
>
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Thanks for your review and help.
I will add your reviewed-by tag on next version.
>
> Next steps for future:
>
> * De-duplicate cache code between fat and exfat. Currently fs/exfat
> cache code is heavily copy-paste of fs/fat cache code.
>
> * De-duplicate UTF-16 functions. Currently fs/exfat has e.g. helper
> functions for surrogate pairs copy-paste from fs/nls.
>
> * Unify EXFAT_DEFAULT_IOCHARSET and FAT_DEFAULT_IOCHARSET. Or maybe
> unify it with other filesystems too.
>
> * After applying this patch series, remote staging exfat implementation.
Yep, I will check them.
>
> --
> Pali Rohár
> pali.rohar@gmail.com
>

\
 
 \ /
  Last update: 2020-01-15 14:06    [W:0.123 / U:1.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site