Messages in this thread | | | Subject | Re: [RFC PATCH v1 1/3] dt-bindings: mmc: combine common mmc and dw-mshc properties | From | Johan Jonker <> | Date | Wed, 15 Jan 2020 14:02:18 +0100 |
| |
Hi,
Thank you for your explanation. I was not aware that was playing. So now we go from a 'simple' txt to yaml conversion to a complete 'change your node name first' operation. Can you indicate if that common yaml file for dw-mshc and Rockchip is still a good idea?
Thanks
On 1/14/20 11:06 PM, Rob Herring wrote: > On Tue, Jan 14, 2020 at 3:38 PM Johan Jonker <jbx6244@gmail.com> wrote: >> >> Combine the common properties for mmc and dw-mshc in >> mmc-controller-common.yaml > > Commit messages should explain the why, not what. > > AFAICT, the only reason is to not have a node name of 'mmc'. That's > entirely the reason why it is defined. Fix your node names to use the > standard name. > > > > Rob >
| |