lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 02/12] ELF: Add ELF program property parsing support
On Wed, Dec 11, 2019 at 03:41:56PM +0000, Mark Brown wrote:
> From: Dave Martin <Dave.Martin@arm.com>
>
> ELF program properties will be needed for detecting whether to
> enable optional architecture or ABI features for a new ELF process.
>
> For now, there are no generic properties that we care about, so do
> nothing unless CONFIG_ARCH_USE_GNU_PROPERTY=y.
>
> Otherwise, the presence of properties using the PT_PROGRAM_PROPERTY
> phdrs entry (if any), and notify each property to the arch code.
>
> For now, the added code is not used.
>
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>

As with the previous patch, this should also go to linux-fsdevel.

The logic looks fine to me but I'm not sure the choice of returning -EIO
is suitable in most cases. I think apart from kernel_read() returning an
error, there rest look like malformed ELF notes, so rather -ENOEXEC.

--
Catalin

\
 
 \ /
  Last update: 2020-01-14 17:34    [W:0.138 / U:39.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site