Messages in this thread | | | From | Adam Thomson <> | Subject | RE: [PATCH 1/3] mfd: da9062: fix watchdog compatible string | Date | Tue, 14 Jan 2020 16:19:04 +0000 |
| |
On 08 January 2020 09:57, Marco Felsch wrote:
> The watchdog driver compatible is "dlg,da9062-watchdog" and not > "dlg,da9062-wdt". Therefore the mfd-core can't populate the of_node and > fwnode. As result the watchdog driver can't parse the devicetree. >
I do agree there's a mismatch between the documentation and the MFD code. So in your DT are you specifying 'dlg,da9062-watchdog' and not 'dlg,da9062-wdt' hence the issue? Are there any existing users who are using 'dlg,da9062-wdt' in their DT instead?
> Fixes: 9b40b030c4ad ("mfd: da9062: Supply core driver") > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > drivers/mfd/da9062-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c > index e69626867c26..9143de7b77b8 100644 > --- a/drivers/mfd/da9062-core.c > +++ b/drivers/mfd/da9062-core.c > @@ -248,7 +248,7 @@ static const struct mfd_cell da9062_devs[] = { > .name = "da9062-watchdog", > .num_resources = ARRAY_SIZE(da9062_wdt_resources), > .resources = da9062_wdt_resources, > - .of_compatible = "dlg,da9062-wdt", > + .of_compatible = "dlg,da9062-watchdog", > }, > { > .name = "da9062-thermal", > -- > 2.20.1
| |