Messages in this thread | | | Subject | Re: [PATCH v1] driver core: Use list_del_init to replace list_del at device_links_purge() | From | John Garry <> | Date | Tue, 14 Jan 2020 15:20:12 +0000 |
| |
On 14/01/2020 15:07, Greg KH wrote: > On Wed, Jan 08, 2020 at 05:04:20PM -0800, James Bottomley wrote: >> On Wed, 2020-01-08 at 17:10 +0000, John Garry wrote: >>> On 08/01/2020 16:08, John Garry wrote: >>>> On 08/01/2020 16:01, James Bottomley wrote: >>>>>>>> cdev->dev = NULL; >>>>>>>> return device_add(&cdev->cdev); >>>>>>>> } >>>>>>>> } >>>>>>>> return -ENODEV; >>>>>>>> } >>>>>>> >>>>>>> The design of the code is simply to remove the link to the >>>>>>> inserted device which has been removed. >>>>>>> >>>>>>> I*think* this means the calls to device_del and device_add >>>>>>> are unnecessary and should go. enclosure_remove_links and >>>>>>> the put of the enclosed device should be sufficient. >>>>>> >>>>>> That would make more sense than trying to "reuse" the device >>>>>> structure here by tearing it down and adding it back. >>>>> >>>>> OK, let's try that. This should be the patch if someone can try >>>>> it (I've compile tested it, but the enclosure system is under a >>>>> heap of stuff in the garage). >>>> >>>> I can test it now. >>>> >>> >>> Yeah, that looks to have worked ok. SES disk locate was also fine >>> after losing and rediscovering the disk. >> >> OK, I'll spin up a patch with fixes/reported and tested tags. > > Did this get sent? I can't seem to find it :( >
Yeah, but you were not cc'ed :(
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200114&id=529244bd1afc102ab164429d338d310d5d65e60d
cheers. John
> . >
| |