Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH 2/2] libertas: make lbs_ibss_join_existing() return error code on rates overflow | Date | Tue, 14 Jan 2020 15:44:30 +0200 |
| |
Nicolai Stange <nstange@suse.de> writes:
> Commit e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss > descriptor") introduced a bounds check on the number of supplied rates to > lbs_ibss_join_existing() and made it to return on overflow. > > However, the aforementioned commit doesn't set the return value accordingly > and thus, lbs_ibss_join_existing() would return with zero even though it > failed. > > Make lbs_ibss_join_existing return -EINVAL in case the bounds check on the > number of supplied rates fails. > > Fixes: e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss > descriptor")
This should be in one line, I'll fix it during commit.
-- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |