lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] ASoC: Add MediaTek MT6660 Speaker Amp Driver
On Tue, 14 Jan 2020 13:47:44 +0100,
Mark Brown wrote:
>
> On Tue, Jan 14, 2020 at 08:44:22AM +0100, Takashi Iwai wrote:
> > Jeff Chang wrote:
>
> > > + if (ret < 0)
> > > + return ret;
> > > + reg_data = (u8)ret;
> > > + if (on_off)
> > > + reg_data &= (~0x01);
> > > + else
> > > + reg_data |= 0x01;
> > > + return regmap_write(chip->regmap, MT6660_REG_SYSTEM_CTRL, reg_data);
>
> > Hm, this looks like an open-code of forced update bits via regmap.
> > But interestingly there is no corresponding standard helper for that.
> > Essentially it should be regmap_update_bits_base() with force=1.
>
> > Mark?
>
> regmap_write_bits().

Oh that obvious one, thanks :)


Takashi

\
 
 \ /
  Last update: 2020-01-14 14:28    [W:0.052 / U:5.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site