Messages in this thread | | | Date | Tue, 14 Jan 2020 13:10:00 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/microcode/amd: fix uninitalized structure cp |
| |
On Tue, Jan 14, 2020 at 12:03:36PM +0000, Colin Ian King wrote: > On 14/01/2020 12:01, Borislav Petkov wrote: > > On Tue, Jan 14, 2020 at 11:51:43AM +0000, Colin Ian King wrote: > >> Starting at load_ucode_amd_bsp(), this initializes a local cp to zero, > >> then passes &cp when it calls __load_ucode_amd() as parameter *ret. In > >> __load_ucode_amd a new local cp is created on the stack and *only* is > >> assigned here: > >> > >> if (!get_builtin_microcode(&cp, x86_family(cpuid_1_eax))) > >> cp = find_microcode_in_initrd(path, use_pa); > > > > Is there any case where cp doesn't get assigned here? Either by > > get_builtin_microcode() or by find_microcode_in_initrd()? ^^^^^^^^^^^^^
You missed this question.
> OK, I will try to extract every special Tag from Coverity and get this > documented when I get some spare cycles.
tglx just explained to me the whole situation about coverity.
I'm not asking about extracting special tags but rather about a couple of sentences somewhere in Documentation/ explaining what Addresses-Coverity* means for the unenlightened among us and how one can find further invormation.
Reportedly, there's even a web page with the tags somewhere...
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |