Messages in this thread | | | Date | Tue, 14 Jan 2020 12:38:34 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/microcode/amd: fix uninitalized structure cp |
| |
On Tue, Jan 14, 2020 at 11:15:05AM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > In the case where cp is not assigned to the return from > the call to find_microcode_in_initrd
Where does this happen? I don't see it.
> cp is uninitialized when > it is assigned to *ret. Functions that call __load_ucode_amd > such as load_ucode_amd_bsp can therefore end up checking bogus > values cp.data and cp.size. Fix this by ensuring cp is > initialized as all zero and remove the redundant initialization > of cp in load_ucode_amd_bsp. > > Addresses-Coverity: ("Uninitialized scalar variable")
I already asked about those: either document what those tags mean or remove them.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |