lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 27/31] scsi: bfa: release allocated memory in case of error
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    commit 0e62395da2bd5166d7c9e14cbc7503b256a34cb0 upstream.

    In bfad_im_get_stats if bfa_port_get_stats fails, allocated memory needs to
    be released.

    Link: https://lore.kernel.org/r/20190910234417.22151-1-navid.emamdoost@gmail.com
    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/bfa/bfad_attr.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/scsi/bfa/bfad_attr.c
    +++ b/drivers/scsi/bfa/bfad_attr.c
    @@ -283,8 +283,10 @@ bfad_im_get_stats(struct Scsi_Host *shos
    rc = bfa_port_get_stats(BFA_FCPORT(&bfad->bfa),
    fcstats, bfad_hcb_comp, &fcomp);
    spin_unlock_irqrestore(&bfad->bfad_lock, flags);
    - if (rc != BFA_STATUS_OK)
    + if (rc != BFA_STATUS_OK) {
    + kfree(fcstats);
    return NULL;
    + }

    wait_for_completion(&fcomp.comp);


    \
     
     \ /
      Last update: 2020-01-14 11:15    [W:4.231 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site