lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dt-bindings: reset: intel,rcu-gw: Fix intel,global-reset schema
From
Date
Hi Rob,

On Mon, 2020-01-13 at 15:45 -0600, Rob Herring wrote:
> The intel,rcu-gw binding example has an error:
>
> Documentation/devicetree/bindings/reset/intel,rcu-gw.example.dt.yaml:
> reset-controller@e0000000: intel,global-reset: [[16, 30]] is too short
>
> The error isn't really correct as the problem is in how the data is
> encoded and the schema is not fixed up by the tooling correctly.
> However, array properties should describe the elements in the array, so
> lets do that which fixes the error in the process.
>
> Fixes: b7ab0cb00d08 ("dt-bindings: reset: Add YAML schemas for the Intel Reset controller")
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Dilip Kota <eswara.kota@linux.intel.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml
> index 246dea8a2ec9..8ac437282659 100644
> --- a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml
> +++ b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml
> @@ -23,7 +23,11 @@ properties:
> description: Global reset register offset and bit offset.
> allOf:
> - $ref: /schemas/types.yaml#/definitions/uint32-array
> - - maxItems: 2
> + items:
> + - description: Register offset
> + - description: Register bit offset
> + minimum: 0
> + maximum: 31
>
> "#reset-cells":
> minimum: 2

Thank you, applied to reset/next.

regards
Philipp

\
 
 \ /
  Last update: 2020-01-14 11:09    [W:0.033 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site