lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'cs_block'
Date
On Dec 26, 2019 / 17:24, Shin'ichiro Kawasaki wrote:
> On Dec 26, 2019 / 14:05, Yuehaibing wrote:
> > On 2019/12/26 11:44, Chao Yu wrote:
> > > On 2019/12/24 20:43, YueHaibing wrote:
> > >> fs/f2fs/segment.c: In function fix_curseg_write_pointer:
> > >> fs/f2fs/segment.c:4485:35: warning: variable cs_block set but not used [-Wunused-but-set-variable]
> > >>
> > >> It is never used since commit 362d8a920384 ("f2fs: Check
> > >> write pointer consistency of open zones") , so remove it.
> > >
> > > Thanks for the fix!
> > >
> > > Do you mind merging this patch to original patch? as it's still
> > > pending in dev branch.
> >
> > It's ok for me.
> >
>
> Thank you for this catch and the fix. Appreciated.

I have merged YueHaibing's change to the write pointer consistency fix patch
and sent out as the v6 series. Thanks again for finding out the unused variable.

I was not sure if I should add Chao Yu's reviewed by tag to the patch from which
the unused variable was removed. To be strict, I didn't add the tag. Just
another quick review by Chao will be appreciated.

--
Best Regards,
Shin'ichiro Kawasaki
\
 
 \ /
  Last update: 2020-01-15 03:34    [W:0.051 / U:112.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site