lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 1/3] dt-bindings: pinctrl: Convert i.MX8MQ to json-schema
Date
Hi, Rob

> Subject: Re: [PATCH V2 1/3] dt-bindings: pinctrl: Convert i.MX8MQ to json-
> schema
>
> On Fri, Jan 10, 2020 at 12:05:18PM +0800, Anson Huang wrote:
> > Convert the i.MX8MQ pinctrl binding to DT schema format using
> > json-schema
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > Changes since V1:
> > - use "grp$" instead of "-grp$";
> > - use space instead of tab for "ref$";
> > - add missed "reg" property;
> > - remove the "maxItem" for "fsl,pins" to avoid build warning, as the
> item number is changable.
> > ---
> > .../bindings/pinctrl/fsl,imx8mq-pinctrl.txt | 36 -----------
> > .../bindings/pinctrl/fsl,imx8mq-pinctrl.yaml | 69
> ++++++++++++++++++++++
> > 2 files changed, 69 insertions(+), 36 deletions(-) delete mode
> > 100644
> > Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt
> > create mode 100644
> > Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml
>
> Actually, it looks like you can combine all 3 into a single schema. The only diff
> is the compatible string.

The header files name, reference manual name and the examples are also different,
so, personally, I prefer to have them separately if no strong objection.

Thanks,
Anson
\
 
 \ /
  Last update: 2020-01-15 02:38    [W:0.047 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site