lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] mm/hotplug: silence a lockdep splat with printk()
On Tue, 14 Jan 2020 20:02:31 -0500 Qian Cai <cai@lca.pw> wrote:

>
>
> >> @@ -8290,8 +8290,10 @@ bool has_unmovable_pages(struct zone *zo
> >> return false;
> >> unmovable:
> >> WARN_ON_ONCE(zone_idx(zone) == ZONE_MOVABLE);
> >> - if (flags & REPORT_FAILURE)
> >> - dump_page(pfn_to_page(pfn + iter), reason);
> >> + if (flags & REPORT_FAILURE) {
> >> + page = pfn_to_page(pfn + iter);
> >
> > This statement appears to be unnecessary.
>
> dump_page() in set_migratetype_isolate() needs that “page”.

local var `page' is never used after this statement.


\
 
 \ /
  Last update: 2020-01-15 02:20    [W:0.030 / U:24.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site