lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mips/vdso: Support mremap() for vDSO
Hi Guoyun,

On Tue, Jan 14, 2020 at 01:13:28PM +0800, Guoyun Sun wrote:
> diff --git a/arch/mips/kernel/vdso.c b/arch/mips/kernel/vdso.c
> index bc35f84..eac3982 100644
> --- a/arch/mips/kernel/vdso.c
> +++ b/arch/mips/kernel/vdso.c
> @@ -38,6 +38,28 @@ static struct vm_special_mapping vdso_vvar_mapping = {
> .pages = no_pages,
> };
>
> +int vdso_mremap(const struct vm_special_mapping *sm,
> + struct vm_area_struct *new_vma)
> +{
> + unsigned long new_size = new_vma->vm_end - new_vma->vm_start;
> +
> +#ifdef CONFIG_MIPS32_O32
> + if (vdso_image_o32.size != new_size)
> + return -EINVAL;
> +#endif
> +
> +#ifdef CONFIG_MIPS32_N32
> + if (vdso_image_n32.size != new_size)
> + return -EINVAL;
> +#endif
> +
> + if (vdso_image.size != new_size)
> + return -EINVAL;
> +
> + current->mm->context.vdso = (void __user *)(new_vma->vm_start);
> + return 0;
> +}
> +

Thanks for the patch; this bit doesn't seem right though. It requires
that all the VDSOs be the same size, which seems questionable. I think
we probably need separate mremap callbacks for each VDSO, so that we can
check the appropriate VDSO size.

Thanks,
Paul

\
 
 \ /
  Last update: 2020-01-15 01:08    [W:0.037 / U:26.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site