lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Making linkat() able to overwrite the target
On Tue, Jan 14, 2020 at 7:06 PM David Howells <dhowells@redhat.com> wrote:
>
> Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> > > Would it be possible to make linkat() take a flag, say AT_LINK_REPLACE,
> > > that causes the target to be replaced and not give EEXIST? Or make it so
> > > that rename() can take a tmpfile as the source and replace the target with
> > > that. I presume that, either way, this would require journal changes on
> > > ext4, xfs and btrfs.
> >
> > Umm... I don't like the idea of linkat() doing that - you suddenly get new
> > fun cases to think about (what should happen when the target is a mountpoint,
> > for starters?
>
> Don't allow it onto directories, S_AUTOMOUNT-marked inodes or anything that's
> got something mounted on it.
>
> > ) _and_ you would have to add a magical flag to vfs_link() so
> > that it would know which tests to do.
>
> Yes, I suggested AT_LINK_REPLACE as said magical flag.
>
> > As for rename...
>
> Yeah - with further thought, rename() doesn't really work as an interface,
> particularly if a link has already been made.
>
> Do you have an alternative suggestion? There are two things I want to avoid:
>
> (1) Doing unlink-link or unlink-create as that leaves a window where the
> cache file is absent.
>
> (2) Creating replacement files in a temporary directory and renaming from
> there over the top of the target file as the temp dir would then be a
> bottleneck that spends a lot of time locked for creations and renames.

Create multiple sub-temp-dirs and use them alternatively.

I think there was a report for overlayfs with the same bottleneck
(copy up uses a temp dir, but now only for non-regular). Hasn't
gotten around to implementing this idea yet.

Thanks,
Miklos

\
 
 \ /
  Last update: 2020-01-14 20:38    [W:0.082 / U:23.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site