lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/7] builddeb: avoid invoking sub-shells where possible
Hi Ben,

On Tue, Jan 14, 2020 at 2:21 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> > +(
> > + cd $srctree
> > + find . arch/$SRCARCH -maxdepth 1 -name Makefile\*
> > + find include scripts -type f -o -type l
> > + find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform
> > + find arch/$SRCARCH -name include -type f
>
> This command is wrong. We currently find all files under all
> directories named "include" under arch/$SRCARCH. (arc, arm and xtensa
> have some per-platform include directories in additional to the per-
> architecture include directory.)
>
> > +
> > + if [ -d arch/$SRCARCH/scripts ]; then
> > + find arch/$SRCARCH/scripts -type f
> > + fi
> > +) > debian/hdrsrcfiles
> > +
> > +{
> > + if is_enabled CONFIG_STACK_VALIDATION; then
> > + find tools/objtool -type f -executable
> > + fi
> > +
> > + find arch/$SRCARCH/include Module.symvers include scripts -type f
> > +
> > + if is_enabled CONFIG_GCC_PLUGINS; then
> > + find scripts/gcc-plugins -name \*.so -o -name gcc-common.h
> > + fi
>
> This is reverting patch 1.
>
> Ben.

Thank you for catching these.

I made a mistake somehow
when I inserted the patch 1, and then
rebased the others on top of it.

I will fix it in v2.


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2020-01-14 09:05    [W:0.063 / U:4.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site