lkml.org 
[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge
From
Date

On 1/12/20 11:03 PM, Wei Yang wrote:
> No functional change, just leverage the helper function to improve
> readability as others.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

I had thought about doing this same thing. :-)
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>

> ---
> mm/gup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 7646bf993b25..7705929cc920 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
> pmdval = READ_ONCE(*pmd);
> if (pmd_none(pmdval))
> return no_page_table(vma, flags);
> - if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
> + if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
> page = follow_huge_pmd(mm, address, pmd, flags);
> if (page)
> return page;
> @@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
> pud = pud_offset(p4dp, address);
> if (pud_none(*pud))
> return no_page_table(vma, flags);
> - if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
> + if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
> page = follow_huge_pud(mm, address, pud, flags);
> if (page)
> return page;
>

\
 
 \ /
  Last update: 2020-01-14 20:07    [W:0.052 / U:15.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site