Messages in this thread | | | Date | Mon, 13 Jan 2020 19:26:12 +0100 | From | Greg KH <> | Subject | Re: [PATCH] Input: keyspan-remote: fix control-message timeouts |
| |
On Mon, Jan 13, 2020 at 06:17:15PM +0100, Johan Hovold wrote: > The driver was issuing synchronous uninterruptible control requests > without using a timeout. This could lead to the driver hanging on probe > due to a malfunctioning (or malicious) device until the device is > physically disconnected. While sleeping in probe the driver prevents > other devices connected to the same hub from being added to (or removed > from) the bus. > > The USB upper limit of five seconds per request should be more than > enough. > > Fixes: 99f83c9c9ac9 ("[PATCH] USB: add driver for Keyspan Digital Remote") > Cc: stable <stable@vger.kernel.org> # 2.6.13 > Signed-off-by: Johan Hovold <johan@kernel.org> > --- > drivers/input/misc/keyspan_remote.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) >
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |