Messages in this thread | | | Subject | Re: [PATCH v2] media: dvb_dummy_tuner: implement driver skeleton | From | "Daniel W. S. Almeida" <> | Date | Mon, 13 Jan 2020 15:23:02 -0300 |
| |
Hi Greg,
I am working on v3. Would you mind clarifying this?
>> + * >> + * The virtual DVB test driver serves as a reference DVB driver and helps >> + * validate the existing APIs in the media subsystem. It can also aid developers >> + * working on userspace applications. >> + * >> + * This dummy tuner should support common TV standards such as DVB-T/T2/S/S2, >> + * ISDB-T and ATSC when completed. >> + * >> + * Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@gmail.com> > Normally this is the first comment line above in this block. >
Just so we're clear, do you mean this? e.g.:
+ * Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@gmail.com> + * + * The virtual DVB test driver serves as a reference DVB driver and helps + * validate the existing APIs in the media subsystem. It can also aid developers + * working on userspace applications. + * + * This dummy tuner should support common TV standards such as DVB-T/T2/S/S2, + * ISDB-T and ATSC when completed. + *
> Not the same license as your .c file? Odd :(
Oops! :(
> If you keep this file, same comments as above for the comment block, but > really, you don't need this .h file at all, just drop it.
OK.
- Daniel
| |